Skip to content

chore: fix date test when GMT is negative #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

This test fails on negative timezones because 2010-03-17 is interpreted as UTC, while the compared date is created in the local timezone. The formatted date then becomes 2010-03-16 because the object is 2010-03-16T23:00:00 GMT-0100 for example.

https://stackoverflow.com/questions/22959453/javascript-date-using-forward-slashes-vs-hyphens

What is the new behavior?

This test no longer fails

@cla-bot cla-bot bot added the cla: yes label Nov 11, 2019
@elena-p
Copy link
Contributor

elena-p commented Nov 21, 2019

test

@elena-p elena-p merged commit b11cc4e into NativeScript:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants